-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set dependencies from git #319
Set dependencies from git #319
Conversation
@andrea689 Could you please change the URLs to the https URLs? The git@github.com URLs only work with ssh keys. |
In general, I haven't tested this, but I guess if someone has a git depedency on mapbox_gl but hasn't cloned the repo, our current approach with the local path dependencies will fail. So I think git dependencies are indeed the better solution. |
@m0nac0 urls updated!
and I had a local dependencies error |
* add multiple maps support * fix ScrollingMapPage example * use local dependencies
+1 for merging, I am also using the master ref |
still getting on this branch
|
pubspec.lock has not been updated |
EDIT: Please forget everything I wrote. I totally misinterpreted pub's error message. The error means that pub tries to download master from the repo, but the pubspec.yaml on master still has the old "../mapbox_gl_platform_interface" dependency as this PR hasn't landed, of course. I just tested it in my fork and everything should be fine after this PR lands. @kleeb Deleting pubspec.lock doesn't solve the error for me, unfortunately.
What do you guys think / do you have more ideas? |
ad. 2 seems valid approach, doesn't feel like too much hassling when you keep feature branches synced |
EDIT: I was wrong, see above For cases 1 and 3, git dependencies on this repo should work again if this: dependency_overrides:
mapbox_gl_platform_interface:
git:
url: https://github.com/tobrun/flutter-mapbox-gl.git
path: mapbox_gl_platform_interface
mapbox_gl_web:
git:
url: https://github.com/tobrun/flutter-mapbox-gl.git
path: mapbox_gl_web is added to the pubspec.yaml of the app using the mapbox_gl plugin. I haven't tested this, yet, but we have something very similar: |
@m0nac0 great idea, you were super close
|
I merged it in master and it is worked on my work project with this: mapbox_gl:
git:
url: https://github.com/tobrun/flutter-mapbox-gl.git only if i want use my local version use: dependency_overrides:
mapbox_gl:
path: ../flutter-mapbox-gl
mapbox_gl_platform_interface:
path: ../flutter-mapbox-gl/mapbox_gl_platform_interface
mapbox_gl_web:
path: ../flutter-mapbox-gl/mapbox_gl_web |
Set dependencies from git (flutter-mapbox-gl#319)
@tobrun @m0nac0 What do you think if we set the dependencies from git? In this way anyone can use the master branch in their projects without problems even if
mapbox_gl_platform_interface
andmapbox_gl_web
are not yet published.